Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picture selector behavior #2964

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

ovinix
Copy link
Contributor

@ovinix ovinix commented Jul 2, 2024

What is this pull request for?

Fixes few issues:

  1. Checkbox becomes invisible after selecting/unselecting an image
  2. Selection toolbar is not visible when one or multiple images are selected

Updates pictures select all behavior:

  • when no pictures selected then all pictures selected
  • when one/many pictures selected then all pictures selected instead of toggling of picture selection state

Closes #2960

Screenshots

image

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@ovinix ovinix requested a review from a team as a code owner July 2, 2024 12:05
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (208b043) to head (42374ed).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2964   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         232      232           
  Lines        6282     6282           
=======================================
  Hits         6031     6031           
  Misses        251      251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thank you 🙏🏻

@tvdeyen tvdeyen added the backport-to-7.2-stable Needs to be backported to 7.2-stable label Jul 5, 2024
@tvdeyen tvdeyen merged commit 7a235c2 into AlchemyCMS:main Jul 5, 2024
37 checks passed
@ovinix ovinix deleted the fix-picture-selector-behavior branch July 5, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.2-stable Needs to be backported to 7.2-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library/Images picture selection is buggy
2 participants