Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jQuery dep #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

graingert
Copy link

No description provided.

@@ -1290,7 +1290,7 @@ angular.module('angular-img-cropper', []).directive("imageCropper", ['$document'

crop = new ImageCropper(canvas, canvas.width / 2 - width / 2, canvas.height / 2 - height / 2, width, height, keepAspect, touchRadius);

$(canvas).data('crop.angular-img-cropper', crop);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

angular has "data" built in

@graingert
Copy link
Author

@AllanBishop is this project still alive?

@lolobosse
Copy link

I use it at least 😉

@graingert
Copy link
Author

It looks like @AllanBishop hasn't been on github for years...

@graingert
Copy link
Author

and his blog is down

@lolobosse
Copy link

We can maybe ping him by email so that the repo is able to survive?

@graingert
Copy link
Author

I'm happy to fork it to an organisation for both of us

@lolobosse
Copy link

Yeah why not :) but he need to put it as deprecated or something

@graingert
Copy link
Author

It looks like he's deleted his whole Internet presence so I doubt he'll do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants