Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build using GitHub Actions #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dahlgren
Copy link

@Dahlgren Dahlgren commented Aug 2, 2020

Build for Linux (Ubuntu), macOS and Windows

Saves archive with built application per platform

@Dahlgren
Copy link
Author

Dahlgren commented Aug 2, 2020

@AngeloD2022
Copy link
Owner

Thank you so much for the binaries! I've been having difficulty deploying it. I will take a look in a bit!

@AngeloD2022
Copy link
Owner

Okay, so I found an issue. I think you may need to include the libraries/frameworks for each platform's binary. It gives me an error because of this.

Build for Linux (Ubuntu), macOS and Windows

Saves archive with built application per platform
@Dahlgren
Copy link
Author

Added bundling of QT dependencies on macOS and Windows. There's is a third party vendoring tool for Linux that can do the same there but I'd assume Linux users rather use their shared QT dependencies managed by the system

https://github.com/Dahlgren/OnHubDesktop/actions/runs/212665064.

@AngeloD2022
Copy link
Owner

Nice, thank you! And this will add build and other related checks to each merge, right? I'm new to GitHub Actions.

@Dahlgren
Copy link
Author

Correct, it will run for all pushes and all pull requests

@Dahlgren
Copy link
Author

The Windows client seem to crash for me but I don't have a Google WiFi setup to test with atm

@AngeloD2022
Copy link
Owner

I will merge this when I get the chance to test it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants