Created TrackingInterceptor as an alternative to TrackedDioClient #1
Conversation
|
Waiting for cfug/dio#1503 to be merged. |
lohnn
force-pushed
the
tracking_interceptor
branch
from
59be32a
to
a0c461c
Compare
|
What's the status on this one, @lohnn? I think I lost the Discord account where we were communicating. |
|
We are still waiting for the Dio team to become active again and merge my PR on their side. Once that is done, this PR should be all good to go. |
|
In regards to your Discord account, it says you are "Deleted user", not sure if it's possible to get it back tho. 🤔 |
Fix RequestTracker request synchronisation. Also fix RequestTracker unit test.
|
How's this PR looking now when Dio 5.0.0 is out? |
We've added supporting Dio 5.0.0 to the roadmap. However, it will be scheduled for next month. Regarding the PRs, I don't know if you're talking about this project's or Dio's repo. You might be talking about the latter, where I'm unfamiliar with the context, but maybe @lohnn can help. |
|
I'll take a look at if I need to reopen the cfug/dio#1503 pr or not for this one to work. Just haven't had time to do so yet. |
|
Okay, so I've done a small test locally now and the status of the connected PR cfug/dio#1503 is that I'll have to reopen that one, fix any potential merge conflicts or breaking changes and still wait for approval. |
|
As the old PR at Dio was closed, there is a new one cfug/dio#1721, hopefully this one is merged soon, then this PR should be able to be merged once they release a new Dio version. |
I just realized that we've never talked about this. From the start, we assume Dio will not get maintained anymore, so we've picked valid (at the first few looks) into our hard fork. Then we got the ownership, so those merged PRs were merged back to the original repo, again. If you can see a linked PR targeting Diox that is merged, it's merged in the Dio too. |
|
Thanks to cfug/dio#1722 this is no longer blocked. |
…gent into tracking_interceptor # Conflicts: # pubspec.yaml
Make skipped error path test work.
|
I'll have a look at your changes and see, and let's then try to get this merged shortly 👍 |
…lutter_agent into tracking_interceptor # Conflicts: # lib/src/tracked_clients/tracked_dio_interceptor.dart # test/tracked_dio_interceptor_test.dart
It seems like it reduces flakiness.
This reverts commit cc2a4d0.
|
|
||
| final Map<RequestOptions, RequestTracker> _activeTrackers = {}; | ||
|
|
||
| @visibleForTesting |
There was a problem hiding this comment.
Was searching for this one. 🍻
The TrackedDioClient had some shortcomings, so I created an interceptor for Dio to have flexibility and support Dio clients without having to keep implementation up to date with DioMixin interface, as Interceptors will most likely have a more stable API surface.
Current shortcomings of this implementation is that StackTrace in error flow will not work until PR cfug/dio#1503 is merged.