Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change the source of assets. #445

Merged
merged 5 commits into from
Nov 22, 2023
Merged

feat: Change the source of assets. #445

merged 5 commits into from
Nov 22, 2023

Conversation

jakubnowicki
Copy link
Member

@jakubnowicki jakubnowicki commented Nov 15, 2023

Closes #446

shiny.semantic no longer uses CDN as the default source of assets. Instead, assets (JS and CSS) come from semantic.assets package. This also enable using themes without network connection.

DoD

  • Major project work has a corresponding task. If there’s no task for what you are doing, create it. Each task needs to be well defined and described.

  • Change has been tested (manually or with automated tests), everything runs correctly and works as expected. No existing functionality is broken.

  • No new error or warning messages are introduced.

  • All interaction with a semantic functions, examples and docs are written from the perspective of the person using or receiving it. They are understandable and helpful to this person.

  • If the change affects code or repo sctructure, README, documentation and code comments should be updated.

  • All code has been peer-reviewed before merging into any main branch.

  • All changes have been merged into the main branch we use for development (develop).

  • Continuous integration checks (linter, unit tests) are configured and passed.

  • Unit tests added for all new or changed logic.

  • All task requirements satisfied. The reviewer is responsible to verify each aspect of the task.

  • Any added or touched code follows our style-guide.

@jakubnowicki jakubnowicki marked this pull request as ready for review November 21, 2023 10:38
Copy link
Contributor

@TymekDev TymekDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@jakubnowicki jakubnowicki merged commit d343a5b into develop Nov 22, 2023
5 checks passed
@jakubnowicki jakubnowicki deleted the remove-cdn branch November 22, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use local assets instead of CDN
2 participants