A few corrections #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C, 1/7 = 0 (integer division) and 1.0/1.7 = 0.14285...
Fix the longwave coefficient for cloud_mode=3 and cloud_mode=4. According to the original references for Brutsaert (1975) and Yajima, the correct coefficient value is 1.24.
Change 1/10 (=0) to 1.0/10.0 (=0.1) to correct this integer division problem.
An increase in volume was assigned to an increase in height, giving great water level increases. This has been corrected by deleting the term Lake[surfLayer].LayerArea in the line 850.
|
Hey Jordi |
|
Dear Jordi: I wonder the L_outfl and W_outfl are the length and width of semi-axis or axis? Cheers |
|
Of course Matt, glad to help. |
Revert the commit 11f58c6. The original formulation was correct. See https://groups.google.com/d/msg/aquaticmodelling/16UWtixxutA/_LRXr1EOCwAJ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think you might be interested in these corrections:
Best,
Jordi