-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mqtt module update #1038
base: master
Are you sure you want to change the base?
mqtt module update #1038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Towflos please squash this all into a succinct set of commits, one per logical change (or, really, just one with a good commit message.
Let me know if you need help doing this; the ArduPilot page on interactive rebase might help you, 'though: https://ardupilot.org/dev/docs/git-interactive-rebase.html
Commits should be prepended with mavproxy_mqtt:
on the first line
I think I need some Help with this. I squashed all the commits into one and changed the message. Do I also need to delete the old commits? |
@Towflos I just had a go at fixing this; the fixes are not trivial, and I'll probably break something. Bit of a mess in here :-) I suggest that you:
Reasonably urgently we need to stop this module from using f-strings and make sure it at least compiles under Python2 f-strings seem to be awesome, just not yet in MAVProxy :-) |
I simplified the convert_to_dict function and added the option to use a username and password for authentication