Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movinghome: Rewrite movinghome module to use NMEAGPS module #1124

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

booo
Copy link

@booo booo commented Nov 23, 2022

The NMEAGPS if activated receives position updates from a NMEA source. We can use the position information in other modules such as this one. This change reduces code duplication and ensures multiple modules can use one NMEA source.

This is still subject to change and testing. But I would like to get some comments on the idea.

The NMEAGPS if activated receives position updates from a NMEA source.
We can use the position information in other modules such as this one.
This change reduces code duplication and ensures multiple modules can
use one NMEA source.
self.usage was not defined. Even in the old module.
@julled
Copy link

julled commented Nov 24, 2022

if this now has a hard dependency on an running NMEAGPS module, this should be checked in init and told to the user if not the case.

@booo
Copy link
Author

booo commented Nov 24, 2022

I'm not sure if we are able to check if a module is loaded. And there could be different modules providing position information.

We can check if no position update arrives and inform the user about that from time to time. The old module did something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants