Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup: Add missing dependencies… #1216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ryanf55
Copy link

@Ryanf55 Ryanf55 commented Aug 5, 2023

Adds matplotlib, opencv-python and wxPython to all distributions. Works on Linux using a virtual environment. I also converted the requirements from a list to set to prevent duplicates.

Note: There is comment in the source code saying that requiring dependencies breaks things:

# note that we do not include all the real dependencies here (like matplotlib etc)
# as that breaks the pip install. It seems that pip is not smart enough to
# use the system versions of these dependencies, so it tries to download and install
# large numbers of modules like numpy etc which may be already installed

I tried building and installing, and it didn't break my pip install. I used a virtual environment. This comment may no longer be valid.

Solves #1215

* matplotlib
* opencv-python
* wxPython

* And, converted to using a set to prevent duplicates

Signed-off-by: Ryan Friedman <[email protected]>
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would break the way mavproxy is often installed on headless companion computers. We could add them only on windows though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants