Audio recording enhacement #1341
Open
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Mar 26, 2024
| @@ -15,6 +17,15 @@ | |||
| print("chat: failed to import pyaudio, wave or openai. See https://ardupilot.org/mavproxy/docs/modules/chat.html") | |||
| exit() | |||
|
|
|||
| def rms( data ): | |||
There was a problem hiding this comment.
Hi, thanks for this. A few things to fix here:
- could you add comments above the function?
- I think we should name the function to be more specific so its purpose is clear. Perhaps calc_audio_volume() and maybe it should return the decibels directly instead of making the caller do that.
- our normal style is no spaces after brackets. So change "def rms( data )" to "def rms(data)"
- I think it's possible that count could be zero if the microphone is not working. In any case we should have protection against divide-by-zero which could happen if count is zero.
rmackay9
reviewed
Mar 26, 2024
| while curr_time < time_stop: | ||
|
|
||
| # logic for recording sound until someone is speaking. | ||
| isSpeaking = True |
There was a problem hiding this comment.
Hi, I think our normal style is to use underscores between variables so let's change "isSpeaking" to "is_speaking".
Also maybe change the comment to be "record sound while user is speaking"
rmackay9
reviewed
Mar 26, 2024
| rms1 = rms(data) | ||
| if rms1!=0.0: | ||
| decibel = 20 * math.log10(rms1) | ||
| isSpeaking = decibel>-80.0 # -80 is the hardcoded threshold. higher number means louder. Set threshold in the range (-100,0) |
There was a problem hiding this comment.
If possible let's move this -80 to be a definition at the top of the file where it will be easier to find.
rmackay9
reviewed
Mar 26, 2024
| @@ -34,7 +45,7 @@ def check_connection(self): | |||
| try: | |||
| self.client = OpenAI() | |||
| except Exception: | |||
| print("chat: failed to connect to OpenAI") | |||
| print("chat: failed to connect to OpenAI - 4") | |||
There was a problem hiding this comment.
I think this change to the print statement can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
The user could only record for a fix 5 seconds
After:
As long as the user is talking everything will be recorded. When the user stops talking it will take a three seconds to stop recording.
Print statements have been removed, for demo purpose please look at the video
demo-record-until-silent-enhancement.mp4