Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cesium submodule #933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

khancyr
Copy link
Contributor

@khancyr khancyr commented Sep 27, 2021

The cesium module is old and doesn't work anymore. I think it best to remove it as it is useless for now

@auturgy
Copy link
Contributor

auturgy commented Oct 1, 2021

I think it does work, just needs documentation (users need their own cesium keys)

@tridge
Copy link
Contributor

tridge commented Oct 1, 2021

I'd rather try and fix the issues.

@khancyr
Copy link
Contributor Author

khancyr commented Oct 2, 2021

This is a significant effort that nobody want to do for years and in the same time people keep pulling this and waste bandwidth and storage with this.

This is also showing down a little CI

@stephendade
Copy link
Contributor

I did have a go a few months ago in trying to update this module.

Due to the Cesium API having changed significantly over the past 3 years (everything the current module uses has been deprecated - most importantly the terrain and tile data formats), this web-facing parts of the module would need to be written almost from the ground-up to work again. It's nowhere near a simple patch or two.

I agree with @khancyr in that I don't see a reason for keeping this module if there's no clear path or volunteer to get it working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants