Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for Subgradient method #262

Open
wants to merge 9 commits into
base: release-draft
Choose a base branch
from
Open

Patch for Subgradient method #262

wants to merge 9 commits into from

Conversation

hideakiv
Copy link
Collaborator

@hideakiv hideakiv commented Mar 2, 2023

For DD/DdMasterSubgrad: Changed the part where the lagrangian was used for the subproblem objective coefficient instead of the sum of the original objective and lagrangian.

@hideakiv hideakiv requested a review from kibaekkim March 2, 2023 22:14
@kibaekkim kibaekkim changed the base branch from release to release-draft March 2, 2023 23:17
@hideakiv
Copy link
Collaborator Author

hideakiv commented May 2, 2023

TODO: Add tests

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +49.46 🎉

Comparison is base (2c9b9e6) 11.88% compared to head (5aebdf0) 61.35%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-draft     #262       +/-   ##
==================================================
+ Coverage          11.88%   61.35%   +49.46%     
==================================================
  Files                 88      121       +33     
  Lines              10743    10192      -551     
==================================================
+ Hits                1277     6253     +4976     
+ Misses              9466     3939     -5527     
Impacted Files Coverage Δ
src/DspConfig.h 100.00% <ø> (+100.00%) ⬆️
src/Model/DecTssModel.cpp 86.15% <ø> (+86.15%) ⬆️
src/Solver/DantzigWolfe/DwBundleDual.cpp 70.29% <ø> (+70.29%) ⬆️
src/Solver/DantzigWolfe/DwBundleDual.h 44.44% <ø> (+44.44%) ⬆️
src/Solver/DantzigWolfe/DwMaster.cpp 35.92% <ø> (+35.92%) ⬆️
src/Solver/DantzigWolfe/DwMaster.h 40.00% <ø> (+40.00%) ⬆️
src/Solver/DualDecomp/DdDriverSerial.cpp 89.36% <ø> (+89.36%) ⬆️
src/Solver/DualDecomp/DdMW.h 33.33% <ø> (+33.33%) ⬆️
src/Solver/DualDecomp/DdMasterSubgrad.cpp 79.78% <ø> (+79.78%) ⬆️
src/Solver/DualDecomp/DdMasterTr.cpp 71.57% <ø> (+71.57%) ⬆️
... and 3 more

... and 99 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants