docs(js): nextjs-13 example #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
axiomofjoy
reviewed
May 22, 2024
axiomofjoy
approved these changes
May 22, 2024
|
|
||
| ## Learn More | ||
|
|
||
| To learn more about Arize Phoenix, take a look at the following resources: |
There was a problem hiding this comment.
Missing the follow-up list.
|
|
||
| const provider = new NodeTracerProvider({ | ||
| resource: new Resource({ | ||
| ["openinference.project.name"]: "nextjs-chat", |
There was a problem hiding this comment.
Suggestion: Use our semantic convention constant here rather than hard-coding.
There was a problem hiding this comment.
Yeah it's not in the conventions right now. #494
| span.setAttributes({ | ||
| [SemanticConventions.OPENINFERENCE_SPAN_KIND]: | ||
| OpenInferenceSpanKind.CHAIN, | ||
| [INPUT_VALUE]: question, |
| }); | ||
| const answer: string = chatCompletion.choices[0].message.content || ""; | ||
| span.setAttributes({ | ||
| [OUTPUT_VALUE]: answer, |
There was a problem hiding this comment.
leaving it off for simplicity. The default mimetype is text so leaving it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #452
Note that I am only able to make this work using Nextjs 13. Otel doesn't seem to "stick" with nextjs 14 as the compilation of the server code strips the instrumentation (patches are removed).