build: fix package miss files #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CountBleck
approved these changes
Nov 9, 2023
.gitignore
Outdated
Comment on lines
13
to
18
| /dist/*.generated.d.ts | ||
| /dist/*.map | ||
| /dist/asc.js | ||
| /dist/assemblyscript.js | ||
| /dist/importmap.json | ||
| /dist/web.js |
There was a problem hiding this comment.
Suggested change
| /dist/*.generated.d.ts | |
| /dist/*.map | |
| /dist/asc.js | |
| /dist/assemblyscript.js | |
| /dist/importmap.json | |
| /dist/web.js | |
| dist/*.generated.d.ts | |
| dist/*.map | |
| dist/asc.js | |
| dist/assemblyscript.js | |
| dist/importmap.json | |
| dist/web.js |
There was a problem hiding this comment.
Also, please make sure my suggestion works after committing it. For all I know, the leading slash matters.
Yes, It is weird that gitignore in dist will influence npm package. |
|
It appears to be a peculiarity with the |
|
This breaks the npm package |
|
@JulianDM1995 This hasn't been published yet. In fact, this'll fix the npm package. |
CountBleck
added a commit
to CountBleck/assemblyscript
that referenced
this pull request
Nov 9, 2023
This allows AssemblyScript#2786 (which fixes the regression from AssemblyScript#2757) to be published as soon as possible. Note that the main branch is the only branch that can be published, since `ref: main` is passed to actions/checkout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.