Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button in UI doesn't always go back to correct page #426

Open
adrake33 opened this issue Dec 17, 2018 · 7 comments
Open

Back button in UI doesn't always go back to correct page #426

adrake33 opened this issue Dec 17, 2018 · 7 comments
Labels
Bug Something isn't working Priority: Medium

Comments

@adrake33
Copy link
Contributor

adrake33 commented Dec 17, 2018

Summary

The Back button on the trading page does not go back to the correct place on the Portfolio page.

Steps to reproduce

  1. Sign into dev.augur.net with test account 0x913dA4198E6bE1D5f5E4a40D0667f70C0B5430Eb.
  2. Scroll down to the Resolved section of the Portfolio:Positions page and go to the second page of markets.
  3. Click on a market, such as "test scalar 8-1"
  4. When the trading page comes up, click on the Back button and note that it returns to the top of the Portfolio:Positions page, not the Resolved section.

Expected behavior

Ideally, the Back button should return to same place on the Portfolio:Positions page. This can be confusing to users.

@adrake33 adrake33 added the Bug Something isn't working label Dec 17, 2018
@adrake33 adrake33 self-assigned this Dec 17, 2018
@adrake33 adrake33 changed the title Back buttons in UI don't always go back to correct page Back button in UI doesn't always go back to correct page Dec 17, 2018
@adrake33 adrake33 removed their assignment Dec 17, 2018
@adrake33
Copy link
Contributor Author

This will likely be resolved by the new trading page redesign, leaving it open for now

@pgebheim
Copy link
Member

pgebheim commented Feb 7, 2019

@bthaile @adrake33 --- Will this actually be taken care of in this new Trading page redesign? If not I think we should just move this into the Bugs epic and decide a priority.

@bthaile
Copy link
Contributor

bthaile commented Feb 8, 2019

It will be less obvious in the redesign. This is an issue of how we handle navigation history and our back buttons.

We do a makeshift version of “back” with users going from trading page to report/dispute and send the user back to trading page, buts a hack.

We need to design for this behavior when building out the redesign.

@JohnDanz
Copy link
Member

so i just tested this with the new design and it seems to go back to the right spot (as mentioned above, because of the redesign this seems to be resolved).

1 similar comment
@JohnDanz
Copy link
Member

so i just tested this with the new design and it seems to go back to the right spot (as mentioned above, because of the redesign this seems to be resolved).

@bthaile
Copy link
Contributor

bthaile commented Apr 19, 2019

moving to design review for testing

@pgebheim
Copy link
Member

@bthaile @JohnDanz -- Joey tested and things are still wonky.

Will probably need to look at all the navigation before launch and make sure things are sane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority: Medium
Projects
None yet
Development

No branches or pull requests

5 participants