Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed counter-reset not working in combination with inline styles #460

Merged
merged 1 commit into from
May 6, 2023
Merged

Fixed counter-reset not working in combination with inline styles #460

merged 1 commit into from
May 6, 2023

Commits on May 2, 2023

  1. Fixed counter-reset not working in combination with inline styles 

    An error is thrown in `resetCounter` when adding an `counter-reset` inline style to an element in combination with a different style (e.g., in head).

This error is caused by the fact that the `addProps` method is called when an element doesn't have `styleProps` (in the `if (!el.styleProps) {` block), before a default value for `counterProps` is set. This is fixed by assigning a default value for `counterProps` before calling `addProps`.

A test case is also added to reproduce the issue and to prevent future regressions.
    @SimonBackx
    SimonBackx committed May 2, 2023
    Configuration menu
    Copy the full SHA
    169739a View commit details
    Browse the repository at this point in the history