-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#453 add width to input control element #1085
base: develop
Are you sure you want to change the base?
Feature/#453 add width to input control element #1085
Conversation
Thank you @chialiotta, we are looking into this |
@dinhlongviolin1 @FabienLelaquais @FredLL-Avaiga |
multiline={multiline} | ||
minRows={linesShown} | ||
/> | ||
<Box width={width} data-testid="textfield-box"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're changing the display mode of the input.
Box is a div => display: block
We want the display to be more like a span (ie inline)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure anymore of what it would render
@chialiotta Could you copy here a screenshot of a page with 2 input side by side ?
ie <|{user_prompt_1}|input|width={500}|><|{user_prompt_2}|input|width=50%|>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines. |
This message is automatic. Just forget about it. We know you are busy right now, and you are still planning to work on it. Take your time, and good luck with your thesis. |
This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines. |
Issue #453