Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Edited the README.md of the 2-sign-in-b2c #423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NikolaBV
Copy link

@NikolaBV NikolaBV commented Apr 1, 2024

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@@ -81,7 +81,7 @@ or download and extract the repository *.zip* file.

```console
cd ms-identity-javascript-react-tutorial
cd 1-Authorization\2-sign-in-b2c\SPA
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No such file path existed.

@@ -81,7 +81,7 @@ or download and extract the repository *.zip* file.

```console
cd ms-identity-javascript-react-tutorial
cd 1-Authorization\2-sign-in-b2c\SPA
cd 1-Authentication\2-sign-in-b2c\SPA
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be what was intended in the README instructions.

@@ -144,7 +144,7 @@ To setup your B2C user-flows, do the following:
### Step 4: Running the sample

```console
cd 1-Authorization\2-sign-in-b2c\SPA
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same problem here

@NikolaBV
Copy link
Author

NikolaBV commented Apr 1, 2024

Reason for pull request

The instructions do not match the file structure of the project.

This is what it currently says in the README:

readme1

readme2

While this is the contents of the Authorization folders:

Authorization 1 - folder
authorization 1 - contents
Authorization 2 - folder
Authorization 2 - contents

None of them include the "2-sign-in-b2c\SPA" directory, while the "1-Authentication" folder contains exactly what is noted in the README.

Authentication - contents

With this pull request I have changed the file paths to the supposed correct ones.

Testing

I have tested the code and it runs as expected, all intended functionality works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant