-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating FunctionsNetHost (dotnet isolated worker) to 1.0.9 #10262
base: dev
Are you sure you want to change the base?
Conversation
…a test to reflect this change.
Many tests depend on the worker config provided by the referenced worker packages. The new DNI worker config requires a specific environment variable ( |
…(loads only in placeholder mode)
...WebJobs.Script.Tests.Integration/ApplicationInsights/ApplicationInsightsEndToEndTestsBase.cs
Outdated
Show resolved
Hide resolved
@@ -1600,7 +1600,6 @@ public async Task Initialize_LogsWarningForExplicitlySetHostId() | |||
|
|||
[Theory] | |||
[InlineData("python", "main.py", "python", "python")] | |||
[InlineData("dotnet-isolated", "app.dll", "dotnet-isolated", "dotnet-isolated")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dotnet isolated worker config was updated to load only in placeholder mode. Few other tests, I was able to set the environment variable and that allows loading the dotnet isolated worker config. But for this test, there are other code path for which this test is running, where we return if we are in placeholder mode.
Considering the fact that, we are in the process of making this app setting a mandatory value, I think it may be okay to remove the "dotnet-isolated" case from this test.
test/WebJobs.Script.Tests/Configuration/LanguageWorkerOptionsSetupTests.cs
Show resolved
Hide resolved
This reverts commit 1d8ee86.
Updating FunctionsNetHost (dotnet isolated worker) to 1.0.9. Azure/azure-functions-dotnet-worker#2552
Updated a test(which uses the actual worker configs) to reflect this change.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
Additional PR information