[AzureMonitorDistro] add tests for aspnetcore instrumentation #44827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
requested review from
cijothomas,
reyang,
rajkumar-rangaraj,
vishweshbankwar and
jsquire
as code owners
|
API change check API changes are not detected in this pull request. |
...etry.AspNetCore/tests/Azure.Monitor.AspNetCoreTestApp/Azure.Monitor.AspNetCoreTestApp.csproj
Show resolved
Hide resolved
...e.Monitor.OpenTelemetry.AspNetCore.Tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests.csproj
Show resolved
Hide resolved
...ests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/E2ETests/AspNetCoreInstrumentationTests.cs
Outdated
Show resolved
Hide resolved
| ? traceTelemetryItems.Any() | ||
| : traceTelemetryItems.Any(predicate); | ||
| }, | ||
| timeout: TimeSpan.FromSeconds(20)); |
There was a problem hiding this comment.
Is there a reason for long time-out?
There was a problem hiding this comment.
Half the tests failed on the CI because no activity was exported.
I just increased the timeout in the last commit to see if they pass when given extra time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Azure.Monitor.AspNetCoreTestApp.This is using the AspNetCore Empty template.
This project will be used by unit tests to write a
WebApplicationFactory-based test.AspNetCoreInstrumentationTests.These tests verify that Request telemetry is created.