Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Aser #398

Open
wants to merge 104 commits into
base: FixStoresLint
Choose a base branch
from
Open

Aser #398

wants to merge 104 commits into from

Conversation

jatinarora1
Copy link

Xfcf

Mor Shemesh and others added 30 commits August 23, 2017 14:16
Create dashboard with Icon Picker
Instrumentation for Node / C# readme
morsh and others added 26 commits March 11, 2018 11:02
update leaflet markers to fix bug with map
New filter dateRangePicker
update some minor issues
Fixed URL in 'DeployToAzure' Badge
Allow for more timespan options
Fixed bug when you supply selectedValues to a MenuFilter via a datasource.

The fromSource function was probably copied over from TextFilter, but MenuFilter uses the plural definition since it allows to filter on multiple values.
…selected_values

Fixed bug with preselected values in MenuFilter
@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ jatinarora1 sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@corbob
Copy link

corbob commented Oct 29, 2019

To copy/paste and slightly edit what @mihaimaruseac has said on a bunch of other PRs:

Seems to have opened 45 PRs recently, at least 23 of which are invalid/Hacktoberfest spam.

@mihaimaruseac
Copy link

Last day these spammers can get their PRs for a t-shirt. I really wish Hacktoberfest would count merged PRs instead of opened PRs.

@corbob
Copy link

corbob commented Oct 30, 2019

I really wish Hacktoberfest would count merged PRs instead of opened PRs.

That could be nice, but I think they're trying to account for the number of PRs that might take longer than the month to actually merge. Perhaps also checking for ones where a maintainer/contributor has commented?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet