Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary DragonFly BSD support #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tuxillo
Copy link
Contributor

@tuxillo tuxillo commented Oct 23, 2019

Changes are untested in linux/darwin

@jllucas jllucas requested a review from gdiazlo October 24, 2019 07:35
Copy link
Contributor

@gdiazlo gdiazlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If jemalloc is the problem then, I would say the PR should address it as "enable / disable the use of jemalloc" instead of a "dragonfly bsd thing".

I don't like to personalize the build process for each OS, but instead, generalize it so it will work the same (yes I know we have already a Darwin thing, but it should disappear too eventually).

Can you change it to enable / disable jemalloc for all the builds and delete the specifics of dargonflybsd?

@tuxillo
Copy link
Contributor Author

tuxillo commented Dec 15, 2019

Not sure how you can turn on/off jemalloc when you have to specify LDFLAGS for each platform in flags.go.

@gdiazlo
Copy link
Contributor

gdiazlo commented Dec 16, 2019

The code is already there, it differenciates between linux and osx. With a new flag which, instead of being called dbsd should be called nojemmalloc or simmilar. On the other hand, does jemalloc support landed on dbsd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants