Move homepage sections into individual components #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think it'll be better to get rid of all import { RESUME_DATA } from '@/data/resume-data'in
and pass all required data as props: /* page.tsx
*/
<Personal about={...} ... />
<Summary summary={...} />
<WorkExperience work={RESUME_DATA.work} />
<Education education={RESUME_DATA.education} />
<Skills skills={...} />
<Projects projects={...} /> |
|
@BartoszJarocki Let me know what you think of this |
saadjhk
reviewed
Jan 16, 2024
| <h2 className="text-xl font-bold">Work Experience</h2> | ||
| {RESUME_DATA.work.map((work) => { | ||
| return ( | ||
| <Card key={work.company}> |
There was a problem hiding this comment.
can be further divided into a work-detail component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving Sections markup into individual components
This PR creates components for sections like personal info, about, projects etc
Reason
The home page has a lot of markup, making it hard to navigate and read. Additional sections will make the readability even worse
Changes
Just took the markup and pasted into a new component just for better readability and ability to add more sections without overcrowding the home page.
The components don't take props, they use the global
RESUME_DATAobject.