Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Fix Julia Data Ingest - Add Packages + DataFrames #116

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

BradyPlanden
Copy link
Collaborator

This fixes the Julia API example by adding DataFrames as a package dependency and as well as adding the required packages to the environment.

Copy link
Collaborator

@mjaquiery mjaquiery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please merge it when you're ready.

Comment on lines +47 to +49
using Pkg

Pkg.add(["HTTP", "JSON", "DataFrames"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it standard Julia practice to install packages within scripts? If so, good addition, thanks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't say it's standard practice, but it is somewhat common for examples. In this case, it's helpful for new users to avoid package installation errors.

using HTTP
using JSON
using DataFrames
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe I missed that line - I must have stuck it in the console rather than executing it from the script! 😆

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've been down that road a few times with the REPL as well 😛

@mjaquiery mjaquiery merged commit 9211a9d into Battery-Intelligence-Lab:main Jul 10, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants