Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

feat: smartgaps: Hide gaps if showing a single window #406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

defer
Copy link

@defer defer commented Aug 5, 2022

Summary

Adds a toggle that will hide gaps if only a single window is visible. The feature is disabled by default.

Implementation added to both the cpp and ts engines.

Breaking Changes

No

UI Changes

Before After
before after

Test Plan

  1. Make sure gaps are enabled, enable the smart gaps toggle, apply.
  2. Put a single window in the workspace, observe that there are no gaps.
  3. Open a second window, observe that there are gaps.

Related Issues

Closes #404

@defer
Copy link
Author

defer commented Aug 5, 2022

I had to bypass precommit hooks because clang-format is complaining about existing code.

@defer defer changed the title [feat] smartgaps: Hide gaps if showing a single window feat: smartgaps: Hide gaps if showing a single window Aug 5, 2022
Currently disabled by default but adds a toggle that will hide gaps if
only a single window is visible.

The feature is implemented both in the cpp and ts engines.
@HanabishiRecca
Copy link

HanabishiRecca commented Sep 16, 2022

Wait, but we already have a such feature:

image

What is the difference?


Yeah, the issue is actually closed #404 (comment)

@dreamcat4
Copy link

@defer So do you think maybe we can close this PR now as un-merged perhaps?

Also (BTW) when i enable this option: "Maximize sole window" it does seem to help or partially fix some other window bug? Whereby the tiling is partially broken / semi-works. Depending on certain windows / some of the virtual desktops / virtual screens. It's all a bit new to me still.

Anyhow if we can know to actual close this PR (that it does not add anything new / or better / worthwhile improvements needed). Then many thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Smart Gaps
3 participants