Frontend build without minify #2472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was useful for debugging, but is not needed anymore.
This commit temporarly adds frontend/web/build files to git, this way we can inspect the different results.
This way built files should have same file name so that we can see the different outputs when changing build config, in future commits. This is only a temporary change for review.
CSS changes seem unrelated.
Frontend build with flag-icons is not deterministic. Maybe due to removed file hashing?
So we can actually read the generated JavaScript output.
Testing if there is this will be optimized somehow.
thisconnect
force-pushed
the
frontend-build-without-minify
branch
from
98bd005
to
171ce2d
Compare
Just explicitly using minifySyntax true (it already defaults to true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.