Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add run swagger js when start server #126

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

zshnb
Copy link
Contributor

@zshnb zshnb commented Jan 2, 2024

Hi, I cloned this repo and try run server in my local, but firstly an error happened

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/zheng/Workbench/github/gpt-crawler/dist/swagger-output.json' imported from /Users/zheng/Workbench/github/gpt-crawler/dist/src/server.js
at new NodeError (node:internal/errors:405:5)
at finalizeResolution (node:internal/modules/esm/resolve:327:11)
at moduleResolve (node:internal/modules/esm/resolve:946:10)
at defaultResolve (node:internal/modules/esm/resolve:1132:11)
at nextResolve (node:internal/modules/esm/loader:163:28)
at ESMLoader.resolve (node:internal/modules/esm/loader:835:30)
at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
at ModuleWrap. (node:internal/modules/esm/module_job:77:40)
at link (node:internal/modules/esm/module_job:76:36) {
code: 'ERR_MODULE_NOT_FOUND'
}

I found in start:server script miss swagger.js generation, so I add this in script.

@adityak74
Copy link
Contributor

@zshnb Thank you for adding it. I missed it while I merged my server PR.

@zshnb
Copy link
Contributor Author

zshnb commented Jan 3, 2024

@zshnb Thank you for adding it. I missed it while I merged my server PR.

no problem, can you help to merge this pr into main?

@adityak74
Copy link
Contributor

@databill86 @marcelovicentegc - I think we can review and get this in so that we can fix the server breaking on start.

Copy link
Collaborator

@marcelovicentegc marcelovicentegc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcelovicentegc marcelovicentegc added the bug Something isn't working label Jan 3, 2024
@marcelovicentegc
Copy link
Collaborator

@zshnb would you mind running a quick npm run fmt or rebasing your PR (since #69 got merged, which adds a pre-commit hook to run this command) to pass the prettier check?

@zshnb
Copy link
Contributor Author

zshnb commented Jan 4, 2024

@zshnb would you mind running a quick npm run fmt or rebasing your PR (since #69 got merged, which adds a pre-commit hook to run this command) to pass the prettier check?

sure I committed with format

@marcelovicentegc marcelovicentegc merged commit c1fc8b6 into BuilderIO:main Jan 4, 2024
5 checks passed
Copy link

github-actions bot commented Jan 4, 2024

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zshnb zshnb deleted the fix-run-server-locally branch January 4, 2024 14:34
hirsaeki pushed a commit to hirsaeki/gpt-crawler-y-upstream that referenced this pull request Mar 27, 2024
fix: add run swagger js when start server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants