Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add prettier check #88

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

kunal00000
Copy link
Contributor

This PR is copy of #48 .
It got messed up while rebasing.

Resolves #47

@marcelovicentegc
Copy link
Collaborator

Nice, @kunal00000! It looks like the test workflow is broken, you might need to run npm run fmt first (https://github.com/BuilderIO/gpt-crawler/pull/88/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R37)

@kunal00000
Copy link
Contributor Author

kunal00000 commented Nov 28, 2023

Umm 🤔, does this workflow need to have fmt command to fix prettier issues.
I thought it was to just check and not edit code by fixing prettier errors.

@marcelovicentegc
Copy link
Collaborator

I woul

Umm 🤔, does this workflow need to have fmt command to fix prettier issues. I thought it was to just check and not edit code by fixing prettier errors.

Sorry I might not have been clear! The workflow doesn't need to format any code, this step should be done on a pre-commit hook IMO (another PR). What I mean is that the prettier check is failing, so you need to run npm run fmt yourself to format the code and once you commit these formatting changes the pipeline will pass 🤗

@kunal00000
Copy link
Contributor Author

kunal00000 commented Nov 28, 2023

Ah got it. How do I do it using pre-commit hook never used it before.

@marcelovicentegc marcelovicentegc changed the title feat: add prettier check chore: add prettier check Nov 28, 2023
@marcelovicentegc marcelovicentegc merged commit d72703c into BuilderIO:main Nov 28, 2023
3 checks passed
Copy link
Collaborator

@marcelovicentegc marcelovicentegc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

hirsaeki pushed a commit to hirsaeki/gpt-crawler-y-upstream that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI
2 participants