Update README.md #487
Update README.md #487
Conversation
✅ Deploy Preview for wonderful-blackwell-a043b5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| "webRoot": "${workspaceFolder}/src", | ||
| "tmpDir": "/home/ericx/Desktop/FirefoxTemp", |
There was a problem hiding this comment.
Use relative path directories to ensure that paths don't get broken
| @@ -20,7 +20,10 @@ | |||
| }, | |||
| "cSpell.words": ["registryref"], | |||
| "editor.codeActionsOnSave": { | |||
| "source.fixAll.eslint": true | |||
| "source.fixAll.eslint": "explicit" | |||
There was a problem hiding this comment.
Why did you change this ?
There was a problem hiding this comment.
Is this a duplicate file ?
| @@ -1,3 +1,11 @@ | |||
| (function() { | |||
There was a problem hiding this comment.
What are you using this for ?
| "x-span": bounds.width, | ||
| "y-span": bounds.height, |
There was a problem hiding this comment.
An you verify whether _xspan and _yspan are not retrieving the right values. If thats the case please create getters for those two properties to return the width and height of the bounds
| console.log(render); | ||
| console.log(featureid); | ||
| console.log(render.bounds); |
There was a problem hiding this comment.
Unnecessary logging, please remove
| @@ -555,6 +559,34 @@ export default class Component { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Gets the mirrorByX of the component | |||
| * @returns {Number} Returns the degree of rotation | |||
There was a problem hiding this comment.
Is it returning degrees of rotation ?
| @@ -142,6 +142,7 @@ export default class Device { | |||
| addComponent(component: Component): void { | |||
| if (component instanceof Component) { | |||
| this.__components.push(component); | |||
| console.log("component",component) | |||
| @@ -363,7 +363,6 @@ export default class Feature { | |||
| deriveRenderName(): string { | |||
| if (!ComponentAPI.library[this.type]) { | |||
| console.error("Type unrecognized, defaulting to template."); | |||
| this._type = "Template"; | |||
There was a problem hiding this comment.
Any particular reason for removing this ? I'm more curious than anything else
There was a problem hiding this comment.
What are you using this for ?
| //Commented out due to additional parameter added to method | ||
| // const render = ComponentPortRenderer2D.renderComponentPort(componentport, [0,0], 0, 0, 0, zfactor); | ||
| // componentportrenders.push(render); |
There was a problem hiding this comment.
So we are not rendering the component ports now ?
No description provided.