Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when user object is gone #978

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Conversation

Chesire
Copy link
Owner

@Chesire Chesire commented Apr 30, 2023

If the user object has been remove somehow, then the user will crash every time they open the config view. Instead execute a log out for the user so they can then log back in.

If the user object has been remove somehow, then the user will crash every time they open the config
view. Instead execute a log out for the user so they can then log back in.
@Chesire Chesire self-assigned this Apr 30, 2023
@commit-lint
Copy link

commit-lint bot commented Apr 30, 2023

Bug Fixes

  • crash when user object is gone (ee34be5)

Contributors

Chesire

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.04 ⚠️

Comparison is base (60d7711) 77.50% compared to head (ee34be5) 77.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
- Coverage   77.50%   77.46%   -0.04%     
==========================================
  Files         150      150              
  Lines        2178     2179       +1     
  Branches      236      236              
==========================================
  Hits         1688     1688              
- Misses        413      414       +1     
  Partials       77       77              
Impacted Files Coverage Δ
...e/nekome/app/settings/config/ui/ConfigViewModel.kt 69.23% <72.72%> (-1.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Chesire Chesire merged commit 5840f5a into master Apr 30, 2023
@Chesire Chesire deleted the fix/crash-with-no-user branch April 30, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant