Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove usage of uninstall modules #981

Merged
merged 3 commits into from
Apr 30, 2023

Conversation

Chesire
Copy link
Owner

@Chesire Chesire commented Apr 30, 2023

Remove the usage of UninstallModules in tests since it is bad performance, and instead use TestInstallIn for all of the APIs.

Move the compose test rule into the base test class so its always created. Also create a new mock
auth module for the AuthApi.
@Chesire Chesire self-assigned this Apr 30, 2023
@commit-lint
Copy link

commit-lint bot commented Apr 30, 2023

Tests

  • move the compose rule into the base test class (77fb357)
  • add test modules for the api calls (89b108f)

Chore

  • downgrade mockk to 1.13.3 (29ecc3c)

Contributors

Chesire

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (523e30a) 77.46% compared to head (29ecc3c) 77.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #981   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files         150      150           
  Lines        2179     2179           
  Branches      236      236           
=======================================
  Hits         1688     1688           
  Misses        414      414           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

MockK after 1.13.3 seems to have an issue with mocking some interface classes, downgrade to 1.13.3
to fix this for now.
@Chesire Chesire merged commit 62c3dae into master Apr 30, 2023
@Chesire Chesire deleted the test/remove-usage-of-uninstall-modules branch April 30, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant