Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/add Croatian (hr) translations #472

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update/add Croatian (hr) translations #472

wants to merge 3 commits into from

Conversation

anotherus3r
Copy link
Contributor

Updates one Croatian translation file and adds another

@anotherus3r
Update strings.xml
34dd069 
Update translation
@anotherus3r
Create strings.xml
3c05b68 
Add translation
roeiedri
roeiedri approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@roeiedri roeiedri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first file is great, thanks
The second one with "pref" strings shouldnt be changed according to language

roeiedri
roeiedri requested changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@roeiedri roeiedri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the second file with the pref strings

@anotherus3r
Copy link
Contributor Author

Please remove the second file with the pref strings

Is it okay now? @roeiedri

@inson1
Copy link

inson1 commented Nov 7, 2023

@anotherus3r ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeiedri roeiedri roeiedri requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anotherus3r @inson1 @roeiedri