-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Entra guest user groups #310
Conversation
Refactored the Microsoft API calls into an "advanced query" which allows filtering with Filtering groups by the |
84871fa
to
714fad1
Compare
Since security enabled groups are now filtered by Microsoft API we can also fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 🫏
Entra guest users have limited visibility into groups via the API. Basically they can only see the group id's they belong to. Both displayName and securityEnabled values are null. However filtering in the request using ``$filter=securityEnabled eq true` still works for guest users. This feature allows returning group UUIDs for guest users. Filtering groups by the `securityEnabled` flag requires using an "advanced query", which requires adding `$count=true` query parameter and a `ConsistencyLevel: eventual` HTTP header. Since security enabled groups are now filtered by Microsoft API we can also fix `TestADGroupsFromGraphResponse` accordingly. Refs: HP-2434
a108b3d
to
a0ab5f5
Compare
Also: - update GitHub Action versions - Use codecov action - Cache pip with setup-python action
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #310 +/- ##
===========================================
+ Coverage 80.29% 80.35% +0.06%
===========================================
Files 91 91
Lines 3775 3787 +12
===========================================
+ Hits 3031 3043 +12
Misses 744 744 ☔ View full report in Codecov by Sentry. |
Entra guest users have limited visibility into groups via the API. Basically they can only see the group id's they belong to. Both displayName and securityEnabled values are null. However filtering in the request using
$filter=securityEnabled eq true
still works for guest users. This feature allows returning group UUIDs for guest users.Refs: HP-2434