Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpflash updates #280

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

Tpflash updates #280

wants to merge 61 commits into from

Conversation

longemen3000
Copy link
Member

No description provided.

@longemen3000
michelsen tp flash: add trend bubbledew todo
8b37950
@longemen3000
some changes in multiphase.jl
2c4a339
@longemen3000
cleaning multiphase
40b6a8f
@longemen3000
add split_phase_binaries
45fcabf
@longemen3000
PCSAFT: add ammonia
186f804
@longemen3000
the magic trick
a427686
@longemen3000
add a fast path in the case of no cross assoc
f3a7e56
@longemen3000
take care of limit (z -> 0) cases
aad18ba
@longemen3000
change x1 solver to bracketed newton
353fe7b
@longemen3000
add some comments
20766e0
@longemen3000
define assoc_shape
8535572
@longemen3000
typos in assoc_similar
cca2a39
@longemen3000
typos
f462c1b
@longemen3000
typos
8da153b
@longemen3000
Merge branch 'tpflash_updates' of https://github.com/ClapeyronThermo/…
142f645 
…Clapeyron.jl into tpflash_updates
@longemen3000
Merge branch 'master' of https://github.com/ClapeyronThermo/Clapeyron.jl
91bdcad 
 into tpflash_updates
@longemen3000
add more overloads for getsites and assoc_shape
e272ad7
@longemen3000
typo again
c12c6a1
@longemen3000
VR-Mie: modify integral term of assoc to allow reuse of I func in VR1…
81e08da 
…5, add test
@longemen3000
another typo in electrolyte_flash
a0f9271
@longemen3000
change docs on assoc options
8164fdf
@longemen3000
fix vr15 test
63f02d1
@longemen3000
allow cr1 mixing rule for pharmaPCSAFT, error in esd rule and suggest…
6c6a736 
… esd_runtime
@longemen3000
typo in vrmie test
12be4e0
@longemen3000
check if we actually converge on the rootfinding of X_exact4
aadeba9
@longemen3000
update symbolics
a316548
@longemen3000
add a check for association based in convexity of polynomial
d2d2905
@longemen3000
forgot to update K
a3fcc27
@longemen3000
mark singlephase if any(isnan,K)
22d79f7
@longemen3000
use static assoc instead of exact solution
cf17cd5
@longemen3000
Merge branch 'master' of https://github.com/ClapeyronThermo/Clapeyron.jl
0f82043 
 into tpflash_updates
@longemen3000
missing test
652d227
@longemen3000
easier building of parametric params
837692e
@longemen3000
improve split_model
ba72c98
@longemen3000
only checks Ks in equilibria for nans
23b7eeb
@longemen3000
typo in split_model for arrays
99cfb7e
@longemen3000
typo in test
269ea5f
@longemen3000
add specific each_split_model for UnitRange
01db07f
@longemen3000
typo in test
f0b6fc3
@longemen3000
remove debug printing
9905abf
@longemen3000
better splitter api
5507734
@longemen3000
update news.md
c082a16
@longemen3000
Merge branch 'master' of https://github.com/ClapeyronThermo/Clapeyron.jl
4ef2a0f 
 into tpflash_updates
@longemen3000
whitespace
cb86381
@longemen3000
whitespace
8bac3c3
@longemen3000
add workaround for phase::String in symbolics ext
d92393d
@longemen3000
define lb_volume(model,T,z), remove redundant methods for T_scale, p_…
bd4bfca 
…scale
@longemen3000
typo in initial_guess
3baf7b6
@longemen3000
optimized impls for I in Mie and Mie15
bdb94b8
@longemen3000
more specific association initial point in the case of 2b-2b-nocross
84afebb
@longemen3000
add dufal association mixing rule
11f0ca1
@longemen3000
x0_volume_liquid and x0_volume_gas, defining z = SA[1.0] is now done …
3354703 
…automatically
@longemen3000
typo in PharmaPCSAFT
c87b4ca
@longemen3000
typo in LKP
7b7c99f
@longemen3000
remove some nondeterministic error in association
5c8f2ee
@longemen3000
Merge branch 'master' of https://github.com/ClapeyronThermo/Clapeyron.jl
d94c38d 
 into tpflash_updates
@longemen3000
use normal vector
31a94b0
@longemen3000
increase timeout time
dd7ea5e
@longemen3000
typo in PCSAFT parametric construction
212d28f
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 67.90890% with 155 lines in your changes missing coverage. Please review.

Project coverage is 77.49%. Comparing base (494a75e) to head (212d28f).

Files Patch % Lines
src/methods/tpd.jl 0.00% 35 Missing ⚠️
src/models/cubic/PR/variants/QCPR.jl 3.22% 30 Missing ⚠️
src/models/SAFT/association.jl 89.72% 15 Missing ⚠️
src/utils/split_model.jl 68.42% 12 Missing ⚠️
...erty_solvers/multicomponent/tp_flash/multiphase.jl 78.37% 8 Missing ⚠️
src/database/ClapeyronParam.jl 68.42% 6 Missing ⚠️
src/models/ECS/ECS.jl 33.33% 6 Missing ⚠️
...ls/SAFT/PCSAFT/variants/gcPCPSAFT/homogcPCPSAFT.jl 0.00% 5 Missing ⚠️
src/models/SAFT/PCSAFT/variants/gcsPCSAFT.jl 0.00% 5 Missing ⚠️
...lvers/multicomponent/tp_flash/Michelsentp_flash.jl 80.95% 4 Missing ⚠️
... and 20 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   77.77%   77.49%   -0.28%     
==========================================
  Files         316      316              
  Lines       22847    23083     +236     
==========================================
+ Hits        17769    17889     +120     
- Misses       5078     5194     +116

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@longemen3000