Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass LC and LANG envvars to pg_ctl calls - closes #343 #965

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fizyk
Copy link
Member

@fizyk fizyk commented Jun 4, 2024

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_number either from issue tracker or the Pull request number

@realDragonium
Copy link

Awesome to see this fixed so fast!

As idea for the tests mentioned in the issue:

  • Create new function which calls subprocess.check_output, as argument you can give it the command it should run.
    • Make sure to returns the value of subprocess.check_output
  • In the test:
    • add a special env variable to _envvars which is unlikely to be on the system by default
    • run the created function with env
    • check the return value of the function to see or it contains the special env variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants