Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused notification icon url SDK-3772 #600

Merged
merged 2 commits into from
Jul 8, 2024
Merged

remove unused notification icon url SDK-3772 #600

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dd0cb4
task(notification) - remove unused notification icon url from core an…
piyush-kukadiya Apr 15, 2024
fd41d77
Merge branch 'feat/bugs/core700qa' into task/notification_icon_url/SD…
CTLalit Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion clevertap-core/src/main/java/com/clevertap/android/sdk/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public interface Constants {
int DEFINE_VARS_EVENT = 8;
String variablePayloadType = "varsPayload";
String WZRK_FETCH = "wzrk_fetch";
String ICON_BASE_URL = "http://static.wizrocket.com/android/ico/";
String NOTIFICATION_CLICKED_EVENT_NAME = "Notification Clicked";
String NOTIFICATION_VIEWED_EVENT_NAME = "Notification Viewed";
String SC_OUTGOING_EVENT_NAME = "SCOutgoing";
Expand Down
6 changes: 0 additions & 6 deletions ...rc/main/java/com/clevertap/android/sdk/bitmap/NotificationBitmapDownloadRequestHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@ class NotificationBitmapDownloadRequestHandler(
)
}

// Simply stream the bitmap
if (!srcUrl.startsWith("http")) {
bitmapDownloadRequest.bitmapPath = "${Constants.ICON_BASE_URL}/$srcUrl"
}


val downloadedBitmap: DownloadedBitmap = iBitmapDownloadRequestHandler.handleRequest(bitmapDownloadRequest)

return Utils.getDownloadedBitmapPostFallbackIconCheck(fallbackToAppIcon, context, downloadedBitmap)
Expand Down
5 changes: 1 addition & 4 deletions clevertap-pushtemplates/src/main/java/com/clevertap/android/pushtemplates/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,7 @@ public static Bitmap getNotificationBitmap(String icoPath, boolean fallbackToApp
if (icoPath == null || icoPath.equals("")) {
return fallbackToAppIcon ? getAppIcon(context) : null;
}
// Simply stream the bitmap
if (!icoPath.startsWith("http")) {
icoPath = Constants.ICON_BASE_URL + "/" + icoPath;
}

Bitmap ic = getBitmapFromURL(icoPath,context);
return (ic != null) ? ic : ((fallbackToAppIcon) ? getAppIcon(context) : null);
}
Expand Down
8 changes: 4 additions & 4 deletions sample/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ android {
applicationId "com.clevertap.demo"
minSdkVersion 21
targetSdkVersion 34
versionCode 200015
versionName "2.0.0-full"
versionCode 6020200
versionName "6.2.2"
multiDexEnabled true
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}
Expand Down Expand Up @@ -152,13 +152,13 @@ dependencies {
implementation "org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.72"
implementation "org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:3.1.1"*/

remoteImplementation("com.clevertap.android:clevertap-android-sdk:6.2.0")
remoteImplementation("com.clevertap.android:clevertap-android-sdk:6.2.1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be part of release cadence pr

remoteImplementation("com.clevertap.android:clevertap-geofence-sdk:1.3.0")
//remoteImplementation("com.clevertap.android:clevertap-xiaomi-sdk:1.5.4")
remoteImplementation("com.clevertap.android:push-templates:1.2.3")
remoteImplementation("com.clevertap.android:clevertap-hms-sdk:1.3.4")

stagingImplementation("com.clevertap.android:clevertap-android-sdk:6.2.0")
stagingImplementation("com.clevertap.android:clevertap-android-sdk:6.2.1")
stagingImplementation("com.clevertap.android:clevertap-geofence-sdk:1.3.0")
//stagingImplementation("com.clevertap.android:clevertap-xiaomi-sdk:1.5.4")
stagingImplementation("com.clevertap.android:push-templates:1.2.3")
Expand Down
Loading