Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic menus logic and gamemanager #20

Merged
merged 3 commits into from
Feb 27, 2020

Conversation

dudash
Copy link
Contributor

@dudash dudash commented Feb 24, 2020

Some really basic menus and game manager integration (currently just score tracking)

Still needs a prettier theme, still needs more options (thinking - config settings and game over).

Addresses #16 and #7

Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please set the Scenes\Main.tscn as the initial game scene?

project.godot Show resolved Hide resolved
@dudash
Copy link
Contributor Author

dudash commented Feb 24, 2020

@rluders it should be already

@rluders
Copy link
Contributor

rluders commented Feb 24, 2020

lgtm

@RoddieKieley
Copy link
Member

Tested locally both a regular macOS build and a HTML5 build. Works good as a regular app, both to start the game and Quit. In the html5 build if you hit Quit it doesn't appear to do anything but then when you go to Play PodEscape you simply get a blank screen. I'm guessing some resources have been released that would be required.

Not sure if the correct action in a html5 build when 'Quit' is clicked is to close the tab, which is potentially not possible, or to detect that you are in a html5 build and disable the button.

@rluders @dudash What do you think?

Copy link
Member

@RoddieKieley RoddieKieley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment; also good call on the mono_crash addition to .gitignore.

@rluders
Copy link
Contributor

rluders commented Feb 25, 2020

@RoddieKieley nice catch about the quit button when the project is exported to HTML. It would be really nice if we could detect if the game was exported to HTML and remove the button in this case. But I have no idea how to do it, or even if its possible.

Maybe this could help: https://docs.godotengine.org/en/3.2/classes/class_os.html

@dudash
Copy link
Contributor Author

dudash commented Feb 26, 2020

Yeah, looks like we could use OS.get_name(). Or just pull the Quit button out completely. Is our target platform going to be HTML?

@dudash
Copy link
Contributor Author

dudash commented Feb 26, 2020

@RoddieKieley OK, Quit button is now hidden in HTML5 mode - that was easy. :)

@rluders rluders merged commit 07a308b into CodeCafeOpenShiftGame:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants