jsdialog: move more code to typescript #9382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move _getGridChild helper where it is used - move types to Definitions.Types.ts - unify types with other JSDialog types Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Idbaa86e3de56926a24c54a56eedcdcf0f53a8c20
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I2e92849c3e621d8b929829ba238ec88aba128246
we use layoutstyle instead Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Ie05f46c2686a01e66c422ed3924cc0a14797322a
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Iaaca45b338bd0687c8016e30fdb4965f0a3fb8f7
|
no functional change |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gokaysatir
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.