Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information label and bound value in CompareConverter sample don't match #1981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Information label and bound value in CompareConverter sample don't match #1981

wants to merge 1 commit into from
+24 −28

Conversation

GeorgeLeithead
Copy link
Contributor

@GeorgeLeithead GeorgeLeithead commented Jun 25, 2024 •
edited
Loading

Description of Change

Changed the value of the Comparingvalue to be 50% of the Slider range, thus matching the label text. Not unit tests or documentation need to be updated.

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

Tested on:

  • Windows 11
  • Android
  • iOS
  • Maccatalyst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Information label and bound value in CompareConverter sample don't match
1 participant
@GeorgeLeithead