Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Update GameConfigurationManager.cs #107

Merged
merged 1 commit into from
Jan 6, 2024
Merged

[Bugfix] Update GameConfigurationManager.cs #107

merged 1 commit into from
Jan 6, 2024

Conversation

laolarou726
Copy link
Member

@laolarou726 laolarou726 commented Jan 6, 2024

Fixed an issue that may cause the failed init of the ConfigManager.


PR-Codex overview

This PR focuses on improving the GameConfigurationManager class by adding a check to prevent duplicate keys in the result dictionary.

Detailed summary

  • Added a check to ensure that the result dictionary does not already contain the key before adding it.
  • If the key already exists, the corresponding value is updated instead of adding a new key-value pair.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@laolarou726 laolarou726 added the 漏洞 Bug 某些功能发生了异常 Something isn't working label Jan 6, 2024
Copy link

sonarcloud bot commented Jan 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@BiDuang
Copy link
Member

BiDuang commented Jan 6, 2024

LGTM

@laolarou726 laolarou726 merged commit 6105725 into master Jan 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
漏洞 Bug 某些功能发生了异常 Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants