Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more detailed log for game launch #116

Merged
merged 2 commits into from
Feb 7, 2024
Merged

add more detailed log for game launch #116

merged 2 commits into from
Feb 7, 2024

Conversation

laolarou726
Copy link
Member

@laolarou726 laolarou726 commented Feb 7, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on making the AssetObjectModelContext class public and adding the static keyword to the GetMSAuthResult method.

Detailed summary

  • Made the AssetObjectModelContext class public.
  • Added the static keyword to the GetMSAuthResult method.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

BiDuang
BiDuang approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@BiDuang BiDuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

神必，但是CF一直说代码质量有问题，怪了

@laolarou726
Copy link
Member Author

神必，但是CF一直说代码质量有问题，怪了

smpp

@laolarou726 laolarou726 merged commit e7cd1ea into master Feb 7, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiDuang BiDuang BiDuang approved these changes

Assignees

@laolarou726 laolarou726

@BiDuang BiDuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laolarou726 @BiDuang