Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log encoding detect #126

Merged
merged 2 commits into from
Mar 6, 2024
Merged

fix log encoding detect #126

merged 2 commits into from
Mar 6, 2024

Conversation

laolarou726
Copy link
Member

@laolarou726 laolarou726 commented Mar 4, 2024

PR-Codex overview

This PR focuses on enhancing encoding handling, adding a new property to a model, and improving game version resolution helpers.

Detailed summary

  • Added System.IO import in EncodingHelper.cs
  • Added ClientVersion property to RawVersionModel
  • Improved encoding handling in DefaultLogAnalyzer.cs
  • Added TryGetMcVersionByClientVersion method in GameVersionHelper
  • Updated error handling in GameResourcesResolveHelper

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@laolarou726 laolarou726 self-assigned this Mar 4, 2024
@laolarou726 laolarou726 added the 漏洞 Bug 某些功能发生了异常 Something isn't working label Mar 4, 2024
BiDuang
BiDuang previously approved these changes Mar 5, 2024
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@laolarou726 laolarou726 requested a review from BiDuang March 5, 2024 07:34
@yueyinqiu
Copy link
Member

yueyinqiu commented Mar 5, 2024

I'm now wondering whether GuessEncoding method could work as expected.

Does it relies on BOM? And will decoding the string in UTF8 in advance break some things?

@yueyinqiu
Copy link
Member

yueyinqiu commented Mar 5, 2024

Meanwhile, is utf7 really used in some cases? If not, I recommend to remove the related codes, since UTF7 is obsolete.

@laolarou726
Copy link
Member Author

I'm now wondering whether GuessEncoding method could work as expected.

Does it relies on BOM? And will decoding the string in UTF8 in advance break some things?

pretty sure its working

Copy link
Member

@yueyinqiu yueyinqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm forced to do that :(

@laolarou726 laolarou726 merged commit 6df92a2 into master Mar 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
漏洞 Bug 某些功能发生了异常 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants