Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix #135

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Hotfix #135

merged 3 commits into from
Mar 22, 2024

Conversation

laolarou726
Copy link
Member

@laolarou726 laolarou726 commented Mar 19, 2024

PR-Codex overview

This PR introduces a new property GameBaseVersion in VersionInfo.cs and refactors the unit conversion logic in DownloadHelper.cs. It also updates how game profiles are processed in DefaultVersionLocator.cs.

Detailed summary

  • Added GameBaseVersion property in VersionInfo.cs
  • Refactored unit conversion logic in DownloadHelper.cs
  • Updated game profile processing in DefaultVersionLocator.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@laolarou726 laolarou726 added the 新功能/改进 enhancement 增加新功能 New feature or request label Mar 20, 2024
yueyinqiu
yueyinqiu previously approved these changes Mar 20, 2024
Copy link
Member

@yueyinqiu yueyinqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you wish

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@yueyinqiu yueyinqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im a approving machine

@laolarou726 laolarou726 merged commit b333a6d into master Mar 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
新功能/改进 enhancement 增加新功能 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants