Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow L5.8 compatibility #572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jsdmultisys
Copy link

Signed-off-by: Jeff Simons Decena [email protected]

Signed-off-by: Jeff Simons Decena <[email protected]>
@bumbummen99
Copy link

Is the " .php_cs.cache" file needed? Also the test will fail on <5.7 framework versions.

@jsdmultisys
Copy link
Author

@bumbummen99 you have a point bec 5.7 down uses fire instead of dispatch, will update this.

The .php_cs.cache is just a cached file for the php-cs-fixer and a good to have but not required

@bumbummen99
Copy link

@jsdmultisys I did not know the latter one, i'll read into it. Otherwise it looks good 👍

@lloricode
Copy link

duplicate #550

@lloricode
Copy link

dont include all updates in one PR, make it in different PR, so it can address the review and manage what is to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants