Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused ember-cached-decorator-polyfill #168

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

simonihmig
Copy link
Contributor

We don't need this, as we are already on an Ember version that supports @cached natively (>= 4.1).

This will also fix running into CrowdStrike/ember-headless-form#146 for the docs-app.

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

⚠️ No Changeset found

Latest commit: 48548f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ynotdraw
Copy link
Contributor

ynotdraw commented Jun 6, 2023

Thank you!

@simonihmig
Copy link
Contributor Author

Hm, publishing the docs failed to cloudflare failed with an auth error. I though this would only happen for external contributors (as secrets are not available in workflow runs)... 🤔

@simonihmig simonihmig merged commit e9c8330 into main Jun 6, 2023
13 of 14 checks passed
@simonihmig simonihmig deleted the remove-unused-polyfill branch June 6, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants