Follow ShellCheck's style guide for Bash scripts #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of ShellCheck recommend using "[[" in Bash scripts. Recent versions of ShellCheck recommend using "|| true" to indicate when errors can be ignored. I like the built-in ":" for this purpose. See: https://github.com/koalaman/shellcheck/wiki/SC2292 See: https://github.com/koalaman/shellcheck/wiki/SC2312 See: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#colon
tony-landreth
approved these changes
Jul 2, 2024
benjaminjb
reviewed
Jul 2, 2024
|
|
||
| // Abort when the PostgreSQL version installed in the image does not | ||
| // match the cluster spec. | ||
| `results 'postgres path' "$(command -v postgres)"`, | ||
| `results 'postgres version' "${postgres_version:=$(postgres --version)}"`, | ||
| `results 'postgres path' "$(command -v postgres ||:)"`, |
There was a problem hiding this comment.
Should we be checking earlier in this script that we have postgres on this container?
There was a problem hiding this comment.
Most things above here are function declarations. The only calls ahead of this are printf and id, so seems early enough to me.
benjaminjb
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of ShellCheck recommend using
[[in Bash scripts and|| trueto indicate when errors can be ignored. I like the built-in:for this purpose.Checklist:
Type of Changes:
What is the new behavior (if this is a feature change)?
Changes to container entrypoints cause rollouts.
Other Information:
See: https://github.com/koalaman/shellcheck/wiki/SC2292
See: https://github.com/koalaman/shellcheck/wiki/SC2312
See: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#colon