Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for Linux, MinGW and macOS #47

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

CI for Linux, MinGW and macOS #47

wants to merge 8 commits into from

Conversation

illwieckz
Copy link
Member

@illwieckz illwieckz commented Jun 24, 2024

CI for Linux, MinGW and macOS

@illwieckz illwieckz force-pushed the illwieckz/ci branch 3 times, most recently from edbbe38 to f1ecfbe Compare June 24, 2024 10:21
@illwieckz
Copy link
Member Author

illwieckz commented Jun 24, 2024

The PR includes #46 to fix the macOS build:

@illwieckz illwieckz force-pushed the illwieckz/ci branch 5 times, most recently from 4e85b6d to ab2a887 Compare June 24, 2024 12:45
@illwieckz illwieckz changed the title CI: add windows, linux and macos build CI: test building for windows, linux and macos Jun 24, 2024
@illwieckz illwieckz changed the title CI: test building for windows, linux and macos CI: test building for Windows, Linux and macOS Jun 24, 2024
@illwieckz illwieckz changed the title CI: test building for Windows, Linux and macOS CI for Linux, MinGW and macOS Jun 25, 2024
@illwieckz
Copy link
Member Author

The codeql/appveyor changes were merged:

The snprintf fixes were merged:

The MinGW fixes are now living in a separate PR:

What is now remaining from this PR is the Azure Pipeline configuration.
I can't test it until Azure Pipeline is enabled for this repository.

azure-pipelines.yml Outdated Show resolved Hide resolved
@illwieckz illwieckz force-pushed the illwieckz/ci branch 2 times, most recently from ff25f12 to 6f58b19 Compare June 28, 2024 16:49
@illwieckz illwieckz force-pushed the illwieckz/ci branch 3 times, most recently from d8c780e to aceaa37 Compare June 28, 2024 17:27
@illwieckz illwieckz force-pushed the illwieckz/ci branch 3 times, most recently from b25332b to 22e8863 Compare June 28, 2024 18:34
@illwieckz illwieckz force-pushed the illwieckz/ci branch 4 times, most recently from b2e7a72 to 5c702dc Compare July 2, 2024 23:27
@illwieckz illwieckz force-pushed the illwieckz/ci branch 3 times, most recently from 6aa5713 to 3c05088 Compare July 3, 2024 17:12
@illwieckz
Copy link
Member Author

illwieckz commented Jul 3, 2024

I added some PNG, BMP and TGA test images from:

When running the Azure CI on a native platform (no cross-compilation), it runs crunch with them as input.

Currently, the test doesn't verify the output of crunch, but it already checks that the input format is not refused, and would catch this kind of error:

It also makes us able to run the test outside the CI and it makes me discover the raw TGA input format is not fully supported (horizontal orientation bit is ignored), I guess the error is in STB and then I would have to report them the error.

@illwieckz illwieckz force-pushed the illwieckz/ci branch 6 times, most recently from 13db8a9 to f8a28ba Compare July 4, 2024 22:44
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -1,17 +1,28 @@
# Crunch

![Crunch logo](crunch.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems kinda weird for a fork to use a logo belonging to the original version of the project

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had mixed feeling about it too. Especially all I wanted was an image to run crunch on, small (no need more) but with enough details to check for the output. I used a 64px unvanquished icon instead: it is small but detailed enough, and features alpha channel with some shadows, so it looks complex enough to me. It is not displayed, just stored in test/.

@illwieckz illwieckz force-pushed the illwieckz/ci branch 3 times, most recently from a5f7dc2 to 7e6dde7 Compare July 5, 2024 01:19
@illwieckz
Copy link
Member Author

illwieckz commented Jul 5, 2024

So, now Linux amd64, macOS amd64 and Windows/MSVC run the tests. The tests are only about running crunch on a set of images and only to check that crunch doesn't error out. We may do some checksums later but that's good enough for now and it's enough to validate the infrastructure is there.

@illwieckz
Copy link
Member Author

illwieckz commented Jul 5, 2024

For some unknown reason, when running in azure pipeline, test/test.py own print call is not displayed in azure pipeline output, same problem with either stdout or stderr output, I have no idea why. That's not a big problem and this may be investigated separately.

@illwieckz illwieckz force-pushed the illwieckz/ci branch 2 times, most recently from ac0b0ed to 668fff3 Compare July 5, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants