DCJ-476: Bypass vault in actions

[rushtong]

Addresses

Partially addresses https://broadworkbench.atlassian.net/browse/DCJ-476

Summary of changes

This PR passes a token to the actions to bypass vault
Requires the following PRs:

• DCJ-476: Remove vault usage in favor of credentials broadinstitute/datarepo-actions#85 (merged)

[cypress]

Passing run #3571 ↗︎

0

26

0

0

0

Details:

Merge e0ee594 into 28d38c0...
Project: jade-data-repo-ui	Commit: dd6c847596 ℹ️
Status: Passed	Duration: 05:44 💡
Started: Jul 3, 2024 2:35 PM	Ended: Jul 3, 2024 2:41 PM

Review all test suite changes for PR #1671 ↗︎

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[okotsopoulos]

Looks good -- thank you! I see that E2E tests ran successfully with the new credentials which gives me confidence that the other workflows will also work, but I'm sure we'll keep an eye out following merge.

Very much out of scope, but seeing all of the places where you've had to change an action version in code made me think that setting the datarepo-actions version in a repo environment variable would be an improvement. Probably not worth the effort if our goal is to remove datarepo-actions soon.

[rushtong]

Very much out of scope, but seeing all of the places where you've had to change an action version in code made me think that setting the datarepo-actions version in a repo environment variable would be an improvement. Probably not worth the effort if our goal is to remove datarepo-actions soon.

Yes, this could be a great follow-on task. I think the conversation around this would depend on what our deployment process should look like - my opinion is that it should not look like what it does now.

[aarohinadkarni]

👍

[okotsopoulos]

Yes, this could be a great follow-on task. I think the conversation around this would depend on what our deployment process should look like - my opinion is that it should not look like what it does now.

@rushtong I share your opinion!