Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Experiment with WDS App Insights metrics reduction #4493

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mflinn-broad
Copy link

@mflinn-broad mflinn-broad commented May 2, 2024

This is the same thing that I did in #4164. I have no intention of merging this. I'm just trying to test a custom build of wds in my bee and don't want to have to jump through the hoops of publishing a new helm chart etc.. so I'm doing this instead. I will close this once I'm done testing.

@mflinn-broad mflinn-broad marked this pull request as draft May 2, 2024 12:32
@@ -386,6 +386,7 @@ azure {
wds-app-config {
environment = "dev"
environment-base = "live"
image: "us-central1-docker.pkg.dev/dsp-artifact-registry/mf-dataplane-metrics-wip/wds:insights"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Often to avoid the whole Leo dance I just kubectl edit deploy on a live WDS/CBAS/etc deployment to change the image and iterate.

Copy link
Author

@mflinn-broad mflinn-broad May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! yeah I know that's faster. wanted to test something end to end :) With a fresh landing zone and clean deploy of wds. I don't actually need to iterate on WDS itself that much. The change I'm making is a one liner. But it's going to be hard to tell if it did the right thing in pre-existing landing zone with a bunch of other WDSes in it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also apparently I don't have kubectl access to landing zone aks clusters and I'm not sure how give that access to myself. I'm being blocked by deny assignments. I am in the terra-workspace-dev AD group

@davidangb
Copy link
Contributor

Whenever you return to this PR, note that while you were out we shipped https://github.com/broadinstitute/terra-helmfile/pull/5519, which reduces WDS frequency to 5 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants