[PROCS-4184] Skip realtime payloads in process and container aggregator in fake-intake #27163
Conversation
wiyu
added
changelog/no-changelog
qa/no-code-change
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=38035325 --os-family=ubuntuNote: This applies to commit 446df17 |
Regression DetectorRegression Detector ResultsRun ID: 4198e064-009b-4144-902a-3a91509a9d32 Metrics dashboard Target profiles Baseline: 8ae0943 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +6.22 | [-6.75, +19.19] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.14 | [+0.26, +2.03] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
| ➖ | idle | memory utilization | -0.04 | [-0.08, -0.01] | Logs |
| ➖ | file_tree | memory utilization | -0.22 | [-0.27, -0.18] | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -0.44 | [-1.25, +0.36] | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.46 | [-3.13, +2.22] | Logs |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -3.03 | [-7.80, +1.75] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
| @@ -44,6 +44,9 @@ func ParseContainerPayload(payload api.Payload) ([]*ContainerPayload, error) { | |||
| switch m := msg.Body.(type) { | |||
| case *agentmodel.CollectorContainer: | |||
| return []*ContainerPayload{{CollectorContainer: *m, collectedTime: payload.Timestamp}}, nil | |||
| case *agentmodel.CollectorContainerRealTime: | |||
There was a problem hiding this comment.
❓ question
Is the aggregator currently failing because the payload is unexpected?
There was a problem hiding this comment.
Yes, this was causing the flakiness issue we were seeing due to the dual shipping in the k8s environment. We'll have future work for to actually handle aggregating these payloads when we add Realtime mode test coverage.
There was a problem hiding this comment.
Ah! That is indeed a bummer! Ok for the fix!
There was a problem hiding this comment.
@wiyu Could you link the Jira card for RT mode coverage here also?
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
This merge request was unqueued If you need support, contact us on Slack #devflow! |
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
This skips aggregating any realtime payloads to avoid flakiness in the k8s e2e tests as the environment is dual shipping to fake-intake and a live backend which enables RT mode.
Motivation
https://datadoghq.atlassian.net/browse/PROCS-4184
Additional Notes
Will have a follow-up PR to remove marking the test as flaky after a few days
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes